Conversation
- 알림 권한 요청 로직 삭제 (TimeReminderScreen) - Home 화면 진입 시 알림 권한 확인하도록 수정 (HomeScreen)
- 홈 화면 진입 시 캘린더 데이터와 일일 일기 데이터를 병렬로 로드하도록 수정 - 데이터 로딩 시 Mutex를 사용하여 동시성 문제 방지 - 중복 데이터 로딩 방지 로직 추가 - `updateSelectedDiaryDate` 함수 제거 및 관련 로직 `updateYearMonthAndLoadData` 함수로 통합 - 네트워크 요청 시 `withContext(Dispatchers.IO)` 사용하여 백그라운드 스레드에서 실행되도록 수정
[REFACTOR/#319] 피커로 연월 변경 시 포커스 개선 및 홈 안정성 증가 시키기
- isUnderInspection 함수에서 점검시간 검사를 초과/미만에서 이상/이하로 개선 + companion object 분리 - getInspectionTimeText 함수에서 단일 책임 원칙에 따라 포맷팅 함수 분리 + companion object 분리
[Feat/#321] 점검시간 다이얼로그 국제화 및 포맷 수정을 진행합니다.
…me-period-change [Refactor/#322] 영어버전 알림시간 설정에서 TimePeriod가 바뀌지 않는 문제를 수정합니다.
…quest [REFACTOR/#317] 알림 권한 로직 개선
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 ISSUE
closed #328
📄 Work Description
✨ PR Point
📸 ScreenShot/Video