Draft
Conversation
- userId にサーバーIDが代入される致命的バグを修正 (entry.getKey()を使用) - loadJson()でJsonSyntaxExceptionを捕捉し、空JSONファイルのNPEを防止 - 辞書マイグレーションを冪等化し、再実行時の二重登録を防止 - ファイル移動処理を改善し、部分的失敗時の整合性を確保
- パッケージプライベートコンストラクタとインスタンスフィールドでパス注入可能に - ファイル移動ロジックをmoveOldData()に切り出し - 全バグ修正をカバーするテストケースを追加
- ディレクトリ未存在時のスキップ - 不正ファイル名のスキップ - 不正ユーザーIDのスキップ - 未対応バージョンのスキップ - dataキー欠落時のスキップ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
migrateServerUserData()で userId にサーバーIDが代入される致命的バグを修正loadJson()でJsonSyntaxExceptionの未捕捉と空JSONファイル時の NPE を修正Test plan
./gradlew buildでビルド成功を確認./gradlew testでテスト通過を確認