Skip to content

Conversation

@michaelzwang13
Copy link
Collaborator

📌 What’s Changed

  • added degree chart so that students can get a better look at the subject categorization of each degree
  • added an overlay toggle so that students can look at how much of their degree they have completed

✅ Actions

  • currently only shows the course code (CSCI-UA, EXPOS-UA, etc.) may want to consider writing (Computer Science, Expository Writing) for better clarity
  • maybe add popup when hovering over the degree chart so users can look at the specific courses they need to take

📝 Notes for Reviewer

  • i committed some mock data and seeding functions for my own testing purposes. i included it as it may be useful to the reviewers. once approved you or i can remove them
  • frontend ui is not perfect, let me know if i can fix anything
  • i can't seem to find my issue on the project board
Screenshot 2025-10-26 at 3 20 47 PM

Copy link
Collaborator

@chenxin-yan chenxin-yan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

> = useQueries(programQueries);

// Collect all unique course codes from all programs
const allCourseCodes = new Set<string>();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are collecting all the course codes, but you should be treating courses with different types separately ("alternative", "required", "options")

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. i now only fetch required and alternative courses as courses with type option already come with the credits attribute. the logic to deal with them separately is in degree-charts.tsx

{ credits: number; courses: string[][] }
> = {};

// FIXME: currently no merging of programs if more than one listed (dual degree), assumes only one program for now
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when getting all the courses form the programs that belongs to student, create a map that maps the program code with the actual program record so we can display program name propertly

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not entirely sure what you mean by that. i currently already display the program name in the chart. are you saying that if a certain user has multiple programs (e.g. Computer Science B.A. and Economics B.A.), I should display it like "Program 1 and Program 2"? if that's the case i'll need to implement logic to merge the requirements of both programs. let me know what you think.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently it only shows the program code instead of the actual program name:
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh okay okay will fix right now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implemented hard coded map, not sure if there's a better way to do it

@chenxin-yan chenxin-yan force-pushed the main branch 3 times, most recently from 551a188 to 78a92a9 Compare November 12, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants