Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade http4k to v6, JDK and Gradle #9661

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

daviddenton
Copy link
Contributor

No description provided.

@p8
Copy link
Contributor

p8 commented Mar 14, 2025

Hey @daviddenton,

Unrelated to this PR, but it seems http4k has more than 10 test mutations, which is no longer allowed:

The number of test mutations will be limited to 10. We do not mind if you open up pull requests between runs to try out various mutations for your framework so long as the total number at any given time does not exceed 10.

#8420

@daviddenton
Copy link
Contributor Author

Hey @daviddenton,

Unrelated to this PR, but it seems http4k has more than 10 test mutations, which is no longer allowed:

The number of test mutations will be limited to 10. We do not mind if you open up pull requests between runs to try out various mutations for your framework so long as the total number at any given time does not exceed 10.

#8420

OK - we'll look at removing some soon. Thanks for pointing it out. 🙃

@daviddenton
Copy link
Contributor Author

Hey @daviddenton,

Unrelated to this PR, but it seems http4k has more than 10 test mutations, which is no longer allowed:

The number of test mutations will be limited to 10. We do not mind if you open up pull requests between runs to try out various mutations for your framework so long as the total number at any given time does not exceed 10.

#8420

@p8 As promised #9676 🙃

@msmith-techempower
Copy link
Member

Well, I confirmed that http4k-helidon-jdbc works on main, but is indeed breaking after this PR's changes.

@daviddenton
Copy link
Contributor Author

yep - I'm not sure what's going on with this. I'll look at it soon. Feel free to close the PR off until I get a chance to look at it 🙃

@daviddenton daviddenton reopened this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants