fix(dhcp): handle empty Option 12 (Host Name) without exception#1955
Open
zaggash wants to merge 1 commit into
Open
fix(dhcp): handle empty Option 12 (Host Name) without exception#1955zaggash wants to merge 1 commit into
zaggash wants to merge 1 commit into
Conversation
ESP8266/ESP32 DHCP clients and some proprietary alarm links (like Somfy Home Alarm Link) send an empty Option 12 (Host Name) during DHCP requests. This patch catches empty Host Name options gracefully, returns string.Empty to avoid exceptions, and exposes a null getter property so the rest of the server treats the device as having no hostname (avoiding local DNS pollution).
Author
|
Fixes issue #1951 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves exceptions on DHCP Option 12 parsing when clients (like Somfy Alarm Link) send empty hostnames.