feat(popup): add multiple instance methods to popup component #3925
+221
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RSS1102
requested review from
HaixingOoO,
NWYLZW,
RylanBot,
ZWkang,
carolin913,
honkinglin and
uyarn
as code owners
HaixingOoO
approved these changes
Oct 29, 2025
commit: |
|
|
uyarn
reviewed
Nov 1, 2025
uyarn
reviewed
Nov 1, 2025
uyarn
reviewed
Nov 1, 2025
| getPortalElement: () => portalRef.current, | ||
| getPopupContentElement: () => contentRef.current, | ||
| setVisible: (visible: boolean) => onVisibleChange(visible, { trigger: 'document' }), | ||
| /** 获取浮层元素 */ |
There was a problem hiding this comment.
这里把文档提供的和内部方法/非文档提供的分开吧 不要交叉 未公开的注释说明下
uyarn
reviewed
Nov 1, 2025
| const triggerEl = getRefDom(triggerRef); | ||
| // 如果没有渲染弹层或不可见则不触发更新 | ||
| if (!popupRef.current || !visible) return; | ||
| if (!popper) return; |
uyarn
reviewed
Nov 1, 2025
| // popper 的实例内部结构可能是 state.elements.reference | ||
| // 尝试兼容不同实现，先赋值再更新 | ||
| if (popper.state) popper.state.elements.reference = triggerEl; | ||
| popper.update?.(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
feat(popup): 添加多个组件实例方法
getOverlay（获取浮层元素）、getOverlayState（获取浮层悬浮状态）、getPopper（获取当前组件 popper 实例）、update（更新浮层内容）本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单