Fix bug with hard coded degree unit for IFCPARAMETERVALUE #1714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IFCPARAMETERVALUE can be in degrees or radians, depending on the project units #4061= IFCTRIMMEDCURVE(#4060,(IFCPARAMETERVALUE(323.620237484974)),(IFCPARAMETERVALUE(359.30146064255)),.T.,.PARAMETER.); #56380=IFCTRIMMEDCURVE(#56379,(IFCPARAMETERVALUE(0.000000000000000)),(IFCPARAMETERVALUE(5.892128296486300)),.F.,.PARAMETER.);
Collaborator
|
@ifcquery can you give me access to update the PR so i can fix the regression and get it merged |
Author
|
I didn't expect the regression to be changed, because the issue occured in a file other than the test files. |
Collaborator
|
@ifcquery not sure what is going wrong. I can fix it here if you can give me permission |
Author
|
@beachtom Sure, permission is given. You should have received a link to accept invite to the creoox repo, from where the PR was created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IFCPARAMETERVALUE can be in degrees or radians, depending on the project units #4061= IFCTRIMMEDCURVE(#4060,(IFCPARAMETERVALUE(323.620237484974)),(IFCPARAMETERVALUE(359.30146064255)),.T.,.PARAMETER.);
#56380=IFCTRIMMEDCURVE(#56379,(IFCPARAMETERVALUE(0.000000000000000)),(IFCPARAMETERVALUE(5.892128296486300)),.F.,.PARAMETER.);