Core/Aura: Fix periodic crit chance snapshot for DoTs#459
Merged
Ovahlord merged 1 commit intoThe-Cataclysm-Preservation-Project:masterfrom Feb 3, 2026
Merged
Conversation
Ovahlord
merged commit ecd9870
into
The-Cataclysm-Preservation-Project:master
0 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Aura::CalcPeriodicCritChance used the non-periodic crit path when
calculating the crit chance snapshot, which requires SPELL_ATTR0_CU_CAN_CRIT.
Pure periodic spells do not have this attribute, resulting in a zero
crit chance snapshot even when SPELL_ATTR8_PERIODIC_CAN_CRIT is set.
Use the periodic crit path when calculating periodic crit chance so
DoTs can correctly crit.
Tests performed: (Does it build, tested in-game, etc)
build
Ingame:
Tested with Shadow Word: Pain (589) and Bane of Agony (980).
After the fix, periodic ticks correctly crit according to caster spell crit chance.