Added SetBit.js, SetBit.test.js in Bit-Manipulation directory #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raklaptudirm
requested changes
Jul 5, 2021
Bit-Manipulation/test/SetBit.test.js
Outdated
| @@ -0,0 +1,21 @@ | |||
| import { setBit } from '../SetBit' | |||
|
|
|||
| test('should set bit at the given bit Position', () => { | |||
There was a problem hiding this comment.
Expand the test message a bit to give as much information as possible.
Here:
Suggested change
| test('should set bit at the given bit Position', () => { | |
| test('Set bit number 0 in 1:', () => { |
There was a problem hiding this comment.
Add this for all the tests.
There was a problem hiding this comment.
@AbhinavXT Do not apply the same name to all of them, replace the 0 and 1 with the bit number and the number respectively.
There was a problem hiding this comment.
Yes, Sorry about that. I will correct the changes.
|
#630 Progress. |
raklaptudirm
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to JavaScript community
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.