This repository was archived by the owner on Sep 20, 2023. It is now read-only.
reduce analyzer requirements installation time#67
Open
xeaon wants to merge 1 commit intoTheHive-Project:masterfrom
Open
reduce analyzer requirements installation time#67xeaon wants to merge 1 commit intoTheHive-Project:masterfrom
xeaon wants to merge 1 commit intoTheHive-Project:masterfrom
Conversation
while your solution to install all analyzer requirements looks clean and easy to understand, i've always been annoyed about how time consuming it is to watch pip & pip3 going through all requirements.txt. I've recently tried to reduce the actual steps by deduplicating all dependencies and combining them, which speeds up the process a lot.
|
+1 agreed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While your solution to install all analyzer requirements looks clean and easy to understand, i've always been annoyed a litte about how time consuming it is to watch pip & pip3 going through all requirements.txt, especially because a lot of analyzers share the same 'base' requirements like
cortexutilsorrequests.So by deduplicating all requirements and combining them into one single requirements file, you can speed p the hole process. As of today, the linecount of
combined_requirements.txtis 71, compared to 277 overall requirements count.It might not be the prettiest solution so feel free to edit, if you're considering to accept this pull request.