Factory Functions: Lesson tidyup and content clarifications #30071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some code blocks split to be easier to follow than trying to follow large comments
Style is more consistent with the rest of the curriculum as well.
Heading added as now required by style guide. Rephrased to link general concept of modules with the current lesson section.
Addresses common confusion with "why not just call the factory function once and omit the IIFE?"
Common confusion that IIFEs are a special construct and not just a func exp called immediately (due to immediate focus on the module pattern). The module pattern doesn't have to be used with factory functions only, just it's one of the more useful use cases.
ManonLef
reviewed
Sep 4, 2025
javascript/organizing_your_javascript_code/factory_functions_and_module_pattern.md
Show resolved
Hide resolved
rlmoser99
requested review from
a team and
JustWaveThings
and removed request for
a team
Contributor
JustWaveThings
left a comment
JustWaveThings
left a comment
There was a problem hiding this comment.
Actually I'll have a little deeper think about this section and repurpose this PR as more content clarification with a side of tidyup, rather than the reverse.
That sounds like a solid plan. I think your example code above is an improvement as well. Thanks for doing this Mao.
Contributor
Author
|
I don't have a huge amount of time right now but plan to rework the currying/closure section (as discussed above) in a separate PR in the next few days, or after this PR gets merged. |
3 tasks
ManonLef
reviewed
Nov 16, 2025
javascript/organizing_your_javascript_code/factory_functions_and_module_pattern.md
Outdated
Show resolved
Hide resolved
Design pattern not the main focus here and singleton stuff isn't expanded on in this lesson. Avoid a terminology-based rabbit hole.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Due to some inconsistencies with code style and usage of comments, some learners miss some things or get confused in the lesson flow when some parts are in normal text and some parts are in longer comments.
There has also been common confusion regarding the point of IIFEs or what IIFEs actually are (perhaps due to focusing immediately on a practical use of IIFEs without giving a more plain example of what an IIFE really just is - people sometimes overthink it's some special specific construct).
This PR
Issue
Closes #29212
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection