fix(android): add null check for player in videoLoaded() to prevent NPE#4903
Closed
vanhci wants to merge 1 commit into
Closed
fix(android): add null check for player in videoLoaded() to prevent NPE#4903vanhci wants to merge 1 commit into
vanhci wants to merge 1 commit into
Conversation
Fixes NullPointerException in ReactExoplayerView.videoLoaded() when player is released before the callback is dispatched. The race condition occurs when ExoPlayer listener posts a callback on the main looper, but before it's dispatched the player is released (nulled), then the callback fires and causes NPE when calling player.isPlayingAd(). Fixes: #4902
github-project-automation
Bot
moved this to To Triage
in React Native Video - Public Roadmap
|
@vanhci you push a PR very quickly to fix this issue a just open Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Summary
Add null check for in method to prevent NullPointerException.
Bug:
Root cause: Race condition where ExoPlayer listener posts callback on main looper, before it's dispatched the player is released (nulled), then the callback fires and causes NPE when calling .
Fix: Changed:
To:
Fixes #4902