You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a rebase of the stale PR #4813 by @robertert (preserved as the first commit, original authorship intact), with the second commit addressing the review feedback from @moskalakamil:
Drop the two inline explanatory comments
Inline the shouldShowControls boolean in updateControllerVisibility
Replace the explicit updateControllerConfig() + exoPlayerView.showController() on fullscreen entry with refreshControlsStyles(), which (after the first commit removes the !controls guard) refreshes visibility unconditionally
Heads up for reviewers: the red CI is unrelated to this change. The job fails at yarn install before the Android build runs, because mute-stream@4.0.0 was recently published with engines.node >= 22 and the workflow pins node-version: 20.x. Since there's no yarn.lock in the repo, fresh installs now resolve to the incompatible version.
Last green Build Android on support/6.x.x: run 26196236832 (2026-05-20). Anything merged into this branch after that point will hit the same failure until the workflow bumps Node (or a lockfile is added).
cc @moskalakamil — you approved #4813; this PR cherry-picks that commit (authorship preserved) and adds a second commit addressing your review nits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4734
Closes #4751
Summary
This is a rebase of the stale PR #4813 by @robertert (preserved as the first commit, original authorship intact), with the second commit addressing the review feedback from @moskalakamil:
shouldShowControlsboolean inupdateControllerVisibilityupdateControllerConfig()+exoPlayerView.showController()on fullscreen entry withrefreshControlsStyles(), which (after the first commit removes the!controlsguard) refreshes visibility unconditionally