Fix iOS player view controller containment#4908
Open
sorinc03 wants to merge 1 commit into
Open
Conversation
github-project-automation
Bot
moved this to To Triage
in React Native Video - Public Roadmap
|
Thanks for your contribution. Is it possible to support Video v7? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
didMove(toParent:)after embedding the iOSAVPlayerViewControllerfor native controls.willMove(toParent: nil)before detaching/removing the controller.Fixes #3138
Test Plan
git diff --checkxcodebuild -list -project ios/RCTVideo.xcodeprojxcodebuild -project ios/RCTVideo.xcodeproj -scheme RCTVideo -configuration Debug -sdk iphonesimulator CODE_SIGNING_ALLOWED=NO build(fails in this standalone clone because React and generated bridge headers are unavailable:unable to resolve module dependency: ReactandRCTVideoSwiftLog.h file not found)Notes
This keeps the change scoped to UIKit containment lifecycle.
AVPlayerViewControllerrelies on being correctly added as a child view controller, and the 6.x branch was missing thedidMove(toParent:)call afteraddChild.