Skip to content

#585 #2319 Load Balancer global configuration #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 46 commits into
base: develop
Choose a base branch
from
Open

#585 #2319 Load Balancer global configuration #2324

wants to merge 46 commits into from

Conversation

raman-m
Copy link
Member

@raman-m raman-m commented Oct 1, 2025 •
edited
Loading

@raman-m
Move the middleware class to the higher-level namespace context
415b2d4
@raman-m
Rename subfolder to 'Balancers'
2185a3c
@raman-m
Move Error classes
47ef46e
@raman-m
Change namespace to match folder structure
9ff6411
@raman-m
Move the interfaces to a separate folder
fe07c70
@raman-m
Move LoadBalancerFactory
e14032f
@raman-m
Move LoadBalancerHouse
b729da9
@raman-m
Move the creators to a separate folder
4fb9ebe
@raman-m
Delete LoadBalancerOptionsBuilder
19ecc09
@raman-m
IfEmpty string extension workaround
5e0a03c
@raman-m
FileRoute inherits from FileDynamicRoute
61896b9
@raman-m
Don't inherit from FileDynamicRoute
d4a70ae
@raman-m
Inherit from FileGlobalDynamicRoute
cf1b8f7
@raman-m
Relocate the RateLimiting property closer to the RateLimitOptions
e7915ff
@raman-m
Rename to DiscoveryDownstreamRouteFinder
18660e0
@raman-m
Move Metadata to FileGlobalDynamicRoute
a143398
@raman-m
Move LoadBalancerOptions to FileGlobalDynamicRoute
9e77f78
@raman-m
Create LoadBalancerOptions based on global configuration
69ca0fc
@raman-m
Parameterless (default) constructor works perfectly for the Route model
2d4f694
@raman-m
Delete RouteBuilder
e430633
@raman-m
Rename DynamicsCreator to DynamicRoutesCreator
716b554
@raman-m
Rename RoutesCreator to StaticRoutesCreator
d33b978
@raman-m
Replace global LB-options of IInternalConfiguration with dynamic rout…
e85000e 
…e's LB-options
@raman-m raman-m added this to the Summer'25 milestone Oct 1, 2025
@raman-m raman-m self-assigned this Oct 1, 2025
@raman-m raman-m added feature A new feature Load Balancer Ocelot feature: Load Balancer Configuration Ocelot feature: Configuration Summer'25 Summer 2025 release Dynamic Routing Ocelot feature: Dynamic Routing labels Oct 1, 2025
@coveralls
Copy link
Collaborator

coveralls commented Oct 1, 2025 •
edited
Loading

Coverage Status

coverage: 91.465% (+0.7%) from 90.77%
when pulling d1766ce on feat-2319
into 3c6f648 on develop.

@raman-m
Copy link
Member Author

raman-m commented Oct 6, 2025 •
edited
Loading

@RaynaldM @ggnaegi
Lazy bones... Come on!
The development is complete. I will write the acceptance tests today, and the unit testing is already done.

Key changes

File models

Key changes 2

LoadBalancer folder

You can review all the files. The folder structure has been reorganized, but you can focus on these specific files:

Unit tests

You could review all the files inside of the Ocelot.UnitTests/LoadBalancer/ folder, but you can focus on these specific files:

Acceptance tests

In progress...

RaynaldM
RaynaldM approved these changes Oct 7, 2025
View reviewed changes
@raman-m
Copy link
Member Author

raman-m commented Oct 8, 2025 •
edited
Loading

@RaynaldM approved these changes on October 7

Raynald, I've implemented all your suggestions, so, check out commit e8c2c47, and the build is green.
Thanks for the approval! It's all thanks to your forward-thinking approach 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaynaldM RaynaldM RaynaldM approved these changes

@ggnaegi ggnaegi Awaiting requested review from ggnaegi

Assignees

@raman-m raman-m

Labels

Configuration Ocelot feature: Configuration Dynamic Routing Ocelot feature: Dynamic Routing feature A new feature Load Balancer Ocelot feature: Load Balancer Summer'25 Summer 2025 release

Projects

None yet

Milestone

Summer'25

Development

Successfully merging this pull request may close these issues.

Load Balancer global configuration

3 participants

@raman-m @coveralls @RaynaldM