Merged
Conversation
Update Translations
Updated the SSH host select initialization in Monitoring.js to ensure event listeners are attached only after options are loaded asynchronously. Bumped plugin version to 3.4.3.
Improved the logic for attaching the change event listener to the SSH host select element by ensuring any existing listener is removed before adding a new one. Also, ensured the toggleSSHButtons function is called after the select is populated, handling both promise and non-promise cases from buildSelectHost.
Refactored toggleSSHButtons to use direct style.display assignments instead of unseen/seen methods for showing and hiding the add and edit buttons.
Updated the toggleSSHButtons function to more reliably extract the selected value from the event object, improving compatibility with different event sources.
Refactored the toggleSSHButtons function to accept either an event or a direct SSHHostId value, improving initialization and event handling. This ensures correct button display when the SSH host select is populated asynchronously or synchronously.
Replaces double quotes with single quotes in the HTML string for the tendance icon to ensure consistency and avoid potential conflicts in attribute quoting.
Updated the tendance icon HTML generation to use escaped double quotes for attribute values, preventing conflicts with surrounding quotes and improving HTML safety.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and new features to the Monitoring plugin, focusing on enhanced health data reporting, better template selection, improved memory usage logging, and internationalization updates. It also includes some workflow and configuration cleanups.
Monitoring health data and UI improvements:
getHealthData) inMonitoring.ajax.phpto provide a comprehensive health summary of all Monitoring equipment, including status, type, SSH info, last refresh, and select command values.Monitoring.class.phpto use specific templates for AsusWRT and Synology devices, falling back to a default otherwise.Logging and memory usage:
pullCustommethod to include the equipment name in log entries and ensure logs are only written when appropriate.Security and code safety:
_tendance#replacement to prevent conflicts and potential injection issues.