Merged
Conversation
Bumped plugin version to 3.4.4, updated multi-language descriptions to reflect expanded monitoring support (Linux, NAS, Proxmox, LXC, ASUS-WRT routers), and revised utilization instructions. Minimum required version updated to 4.4.2.
Cleaned up HTML templates by removing unused data attributes (such as data-perso-name, data-perso-date-value, data-perso-collect, and data-perso-icon) from tooltip divs in AsusWRT, Monitoring, and Synology dashboard and mobile templates. This simplifies the markup and improves maintainability.
Replaces incorrect 'el' variable with 'memoryEl' in the memory usage percentage HTML assignment to ensure correct element is updated.
Introduces tendance (trend) display for custom and Synology values in mobile and dashboard templates. Updates HTML attributes and rendering logic to include tendance information for threshold and percentage values, improving monitoring detail.
Removed redundant label arguments from buildThresholdHTML calls for load averages in AsusWRT, Monitoring, and Synology mobile templates. Also fixed Synology volume percentage rendering to include tendance inside the percent span.
Moved the tendance string outside the state span element in AsusWRT, Monitoring, and Synology mobile templates to ensure correct HTML structure and styling.
Standardizes the handling of trend indicators (tendance) and prefix formatting across dashboard and mobile templates for AsusWRT, Monitoring, and Synology. Trend indicators are now displayed outside the main value span, and prefixes are consistently formatted without trailing parentheses. Also updates Synology mobile template to use percent values directly and simplifies data attributes.
Replaced all USB and eSATA related template variables with new 'hddusb' and 'hddesata' naming conventions in Synology.html. This improves consistency and likely aligns with backend changes.
Refactor dashboard and mobile templates to pass tendance (trend) values using data-* attributes instead of direct template substitution. Update JavaScript to read tendance values from these attributes, improving HTML escaping and reliability for dynamic icon rendering. Also, use single quotes for HTML attributes in Monitoring.class.php to avoid conflicts.
A debug log statement was added to output the tendance value and corresponding icon for better traceability during stats processing in the Monitoring class.
The tendance (trend) value now stores only the CSS class (e.g., 'arrow-up', 'arrow-down', 'minus') in PHP, and the HTML icon is constructed in JavaScript templates for both dashboard and mobile views. This improves separation of concerns and flexibility in icon rendering.
Replaces raw trend string display with corresponding FontAwesome icons (arrow-up, arrow-down, minus) for custom statistics in both dashboard and mobile templates (AsusWRT, Monitoring, Synology). This improves the visual representation of trends and ensures consistency across all views.
Corrected inconsistent indentation and improved code formatting in AsusWRT and Synology HTML templates for both dashboard and mobile views. These changes enhance code readability and maintainability without altering functionality.
Enhanced the CPU temperature display by adding visual trend icons (arrow-up, arrow-down, minus) based on the trend data. This improves clarity for users monitoring temperature changes across AsusWRT, Monitoring, and Synology templates in both dashboard and mobile views.
This reverts commit 620f612.
Updated the tendanceStr logic to render an icon with appropriate styling when synoTendance is present and valid, improving the visual feedback in the Synology mobile template.
Replaces usage of dataset property with getAttribute for reading 'data-load-avg-*-tendance' attributes, ensuring correct retrieval of custom data attributes for load average widgets.
Replaced usage of dataset properties with getAttribute to retrieve 'tendance' values for load average elements in AsusWRT, Synology, and Monitoring templates. This improves compatibility with custom data attribute naming conventions.
Renamed variables and attributes from syno_v2, syno_v3, and syno_v4 to syno_hddv2, syno_hddv3, and syno_hddv4 in the Synology.html template for improved clarity and consistency with existing naming conventions.
Eliminated a debug log statement in the tendance calculation section of Monitoring.class.php to reduce unnecessary logging output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.