fix(autotools): add tox_log_level.h to public headers list #2928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
Green-Sky
requested changes
Nov 12, 2025
appr0ve
force-pushed
the
autotools_fix
branch
from
3693528 to
57ee3d4
Compare
Member
|
@appr0ve we require commits to be signed by you. |
The tox_log_level.h header file was added as a public API header in version 0.2.21, but was not included in the libtoxcore_la_include_HEADERS variable in toxcore/Makefile.inc. This caused the header to not be installed when building with autotools, leading to compilation errors for applications that include tox_options.h (which depends on tox_log_level.h, like qTox). This patch adds tox_log_level.h to the list of installed headers, matching the behavior of the CMake build system. Commit: c834472 Fixes: compilation error "tox_log_level.h: No such file or directory"
appr0ve
force-pushed
the
autotools_fix
branch
from
57ee3d4 to
ab6e816
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tox_log_level.h header file was added as a public API header in
version 0.2.21, but was not included in the libtoxcore_la_include_HEADERS
variable in toxcore/Makefile.inc. This caused the header to not be
installed when building with autotools, leading to compilation errors
for applications that include tox_options.h (which depends on
tox_log_level.h, like qTox).
This patch adds tox_log_level.h to the list of installed headers,
matching the behavior of the CMake build system.
Commit: c834472
Fixes: compilation error "tox_log_level.h: No such file or directory"
This change is