refactor(crypto): implement increment_nonce via increment_nonce_number - #3079
Open
NoxToxCipher wants to merge 1 commit into
Open
refactor(crypto): implement increment_nonce via increment_nonce_number#3079NoxToxCipher wants to merge 1 commit into
NoxToxCipher wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
refactor
Deduplicate nonce increment logic by having increment_nonce call increment_nonce_number(nonce, 1). Resolves the existing TODO.
NoxToxCipher
force-pushed
the
refactor-increment-nonce
branch
from
September 7, 2026 10:34
c1d1208 to
60a1c4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deduplicate the carry loop in
increment_nonceby callingincrement_nonce_number(nonce, 1), addressing the existing TODO.This change is