Splitscreen Viewer#463
Open
PedroVillegas wants to merge 2 commits into
Open
Conversation
Owner
|
Hi Pedro, thanks for the PR! I think I'll pass on the feature for now -- AFAIK, according to studies, flipping back and forth between images makes differences easiest to detect. (And my own perception seems to agree on this.) Basically, I don't see a point in having split-screen (or side-by-side) views if flipping is an option. I'll leave the PR open for discoverability, though, if you don't mind. EDIT: that aside, the PR would also need implementations for the histogram, the pixel value overlay (when zoomed far enough in), and image save / Ctrl+C in order to get merged. All that extra special casing maintenance overhead is part of the reason I'm hesitant to just merge anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Tom,
As indicated by the title, this PR adds a splitscreen viewer when overlaying images as an alternative to the error metrics. Simply overlay two images, toggle the 'splitscreen' button then click and hold the right mouse button to drag the slider across the images. I encourage you to test it out in case you are interested in the feature.
Note: I have left out the implementation for the metal shader as I don't have a machine to test those changes.
Pedro.