This repository was archived by the owner on Mar 9, 2025. It is now read-only.
Add UI icon for Read-only note #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copied from triliumnext/notes/node_modules/boxicons/svg/regular
eliandoran
approved these changes
Mar 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a while to puzzle out why only some pages I import from html have a pencil icon at the top right: the pages are long so are loaded in Read-only mode to maintain performance.
I added an example of the icon to the Text Notes page, as well as wording clarification. It would make sense to do the same for all UI elements, however I only did this single example in anticipation that moving the whole knowledge-base to Trilium hosted (#117) is not far off (so no need to add all 1600 icon svg files to repo).