build: improvements for TS & Webpack #1225
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this prevents tsc from unnecessarily transpiling the frontend part as well: previously it was transpiled by tsc, but the files got discarded and replaced by the files built by webpack. speeds up tsc command a bit as well: from 14 seconds to ~8 secs
output the bundled files directly in the build folder a) keeps the src folder clean from build output b) it saves us some "manual" copying work
as per https://webpack.js.org/configuration/devtool/#production serving the `source-map` file to "normal" users seems to be not recommended, so instead let's go with `nosources-source-map`: a) this drastically reduces app-dist folder size from 20MB down to 8.7MB b) it still allows for stack traces
not sure why, but seems like it doesn't like `[jt]s` – which causes it to skip certain .d.ts files, making tsc fail
since we build into the build folder -> we should also clean the folder before building as well also it makes sense to run tsc first, as it runs faster, so if there's any TS errors, we will have a faster failing build
…inifying speeds up bundling times __heavily__
pano9000
force-pushed
the
build_improve-ts-webpack
branch
from
ad7643c to
5e9a33d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR (still in draft) aims to improve the build process and better utilize TS / Webpack combination
still a little bit work left to do here, but wanted to make this more visible to avoid any "duplicated work", while I work on this.