Conversation
travispaul
reviewed
Jun 30, 2026
| privilege drop until the creation of a file occurs. | ||
|
|
||
| Also, due to SmartOS customer complaints, and our requirement to have the | ||
| global zone communicat with HVM zones over the virtual serial port, the bhyve |
Author
There was a problem hiding this comment.
Will fix and resolve this on next push. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm opening up this for review even though it isn't finished yet (KEBE comments exist). The prologue is at worst a start. I wanted to make sure some expectations got set before anyone starts on the list and wonders, "WHY?"
Even as I work on this, I may find things that either just don't need to be there anymore, OR really should be upstreamed, even if they weren't due to ENOCYCLES on the part of past folks.