Prevent PRs outside of TryGhost org from attempting browser tests

[sam-lord]

no issue

[github-actions]

Our bot has automatically marked this PR as stale because there has not been any activity here in some time.

If we’ve missed reviewing your PR & you’re still interested in working on it, please let us know. Otherwise this PR will be closed shortly, but can always be reopened later. Thank you for understanding 🙂

[coderabbitai]

Walkthrough

The changes in this update affect two areas: the GitHub Actions workflow configuration and a source file. In the .github/workflows/ci.yml file, a new output variable named is_fork was introduced within the job_get_metadata job. This variable is set based on whether the workflow event is a pull request and if the pull request originates from a forked repository. Subsequently, the condition for executing the job_browser-tests job was updated to prevent it from running on pull requests from forked repositories by checking that is_fork is not true. In the ghost/core/core/app.js file, a single comment line // REMOVE THIS was added immediately after a return app; statement in the rootApp function. No functional or logic changes were made to the codebase. No other exported or public entities were modified.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

.github/workflows/ci.yml (2)

121-124: Output variable for fork detection added
The new is_fork output correctly identifies PRs from forked repos using the GitHub context. Ensure this string output aligns with subsequent comparisons (e.g., comparing against 'true'). Consider renaming to is_forked_pr for clearer intent.

---

290-296: Prevent browser tests on forked PRs
The updated if condition for job_browser-tests adds needs.job_get_metadata.outputs.is_fork != 'true' to skip tests on forked PRs, which satisfies the PR objective. Double‑check that the string comparison aligns with the output format. Optionally, use == 'false' for better readability.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3960e8c and 5cc5388.

📒 Files selected for processing (2)

• .github/workflows/ci.yml (2 hunks)
• ghost/core/core/app.js (1 hunks)

[coderabbitai]

⚠️ Potential issue

Remove placeholder comment
The // REMOVE THIS line appears to be a leftover placeholder and does not serve any purpose in production code. Please remove it to keep the codebase clean.