Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update newsletter.json #22480

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update newsletter.json #22480

wants to merge 2 commits into from

Conversation

agota1229
Copy link

Everything provided with Hungarian translation

Got some code for us? Awesome 🎊!

Please include a description of your change & check your PR against this list, thanks!

  • There's a clear use-case for this code change, explained below
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!

Everything provided with Hungarian translation
Copy link
Contributor

coderabbitai bot commented Mar 13, 2025

Walkthrough

The pull request updates the Hungarian localization for a newsletter-related component by adding complete translations to the ghost/i18n/locales/hu/newsletter.json file. Previously, several keys contained empty strings, and now they have been replaced with meaningful Hungarian text. The changes include translations for various subscription and interface messages such as membership prompts, subscription management options, and user navigation elements. The update ensures that keys like "Become a paid member of {site} to get access to all premium content." and "Comment" now display their Hungarian equivalents accurately. No modifications were made to the declarations of exported or public entities.

Suggested labels

affects:i18n

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
ghost/i18n/locales/hu/newsletter.json (2)

3-5: Review of Primary Content Translations.
The Hungarian translations for the keys:

  • "Become a paid member of {site} to get access to all premium content." (line 3)
  • "By {authors}" (line 4)
  • "Comment" (line 5)
    are generally accurate and maintain the placeholder integrity. However, the translation on line 3 contains an extra trailing whitespace that should be removed for consistency.
-    "Become a paid member of {site} to get access to all premium content.": "Legyen {site} előfizető, hogy minden értékes tartalmunkhoz hozzáférjen. ",
+    "Become a paid member of {site} to get access to all premium content.": "Legyen {site} előfizető, hogy minden értékes tartalmunkhoz hozzáférjen."

23-27: Subscription Detail Messages and Whitespace Cleanup.
The extended subscription-related messages are translated accurately:

  • Line 23: The message about the free trial ending is clear.
  • Line 24: The cancellation notification maintains the original intent.
  • Line 25: The expired subscription message is succinct.
  • Line 26: Contains an extra trailing whitespace in the translation which should be removed for consistency.
  • Line 27: The renewal message is correctly rendered.
-    "Your subscription will expire on {date}.": "Az előfizetés lejáratának dátuma {date}. ",
+    "Your subscription will expire on {date}.": "Az előfizetés lejáratának dátuma {date}."
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 53d19de and a2a07ff.

📒 Files selected for processing (1)
  • ghost/i18n/locales/hu/newsletter.json (1 hunks)
🔇 Additional comments (4)
ghost/i18n/locales/hu/newsletter.json (4)

7-10: Email and Basic Interface Terms Translations.
The translations for the following keys are clear and appropriate:

  • "Email" (line 7): Translated as "E-mail".
  • "free" (line 8): Translated as "ingyenes".
  • "Keep reading" (line 9): Translated as "Tovább olvasok".
  • "Less like this" (line 10): Translated as "Kevesebb".

11-14: Subscription Management Keys Translations.
The following keys related to subscription management are translated correctly:

  • "Manage subscription" (line 11): "Előfizetés kezelése".
  • "Member since" (line 12): "Előfizetés dátuma".
  • "More like this" (line 13): "Több ilyet".
  • "Name" (line 14): "Név".

15-17: Subscription Status and Details Translations.
The translations for:

  • "paid" (line 15): "fizetve".
  • "Subscription details" (line 16): "Előfizetés részletei".
  • "trialing" (line 17): "próbaidő alatt".
    are clear and properly convey the intended meanings.

18-22: Action-Oriented Content Translations.
The keys translated in this segment deal with actionable items and user notifications:

  • "Unsubscribe" (line 18): "Leiratkozás".
  • "Upgrade" (line 19): "Csomagváltás".
  • "Upgrade to continue reading." (line 20): "Válts csomagot, hogy olvass tovább."
  • "View in browser" (line 21): "Megnyitás böngészőben".
  • The detailed subscriber message (line 22) preserves the HTML tags and placeholders correctly.

cathysarisky

This comment was marked as outdated.

@cathysarisky
Copy link
Contributor

Thank you for this contribution! We actually already have work going on over in #21982 . Would you like to review that one, instead of starting a fresh one here? Thanks!

@cathysarisky
Copy link
Contributor

Hey @agota1229 , #21982 has been merged. Could you please have a look at it (either the submitted files or live on your site in a few days) and see if you think additional work on the translations is needed?

You could close this PR if no further work is necessary, or else if you want to use it to propose changes to the accepted changes, please start by using the "Resolve conflicts" button to bring your PR up to the current state of the translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants