-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update newsletter.json #22480
base: main
Are you sure you want to change the base?
Update newsletter.json #22480
Conversation
Everything provided with Hungarian translation
WalkthroughThe pull request updates the Hungarian localization for a newsletter-related component by adding complete translations to the Suggested labels
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
ghost/i18n/locales/hu/newsletter.json (2)
3-5
: Review of Primary Content Translations.
The Hungarian translations for the keys:
- "Become a paid member of {site} to get access to all premium content." (line 3)
- "By {authors}" (line 4)
- "Comment" (line 5)
are generally accurate and maintain the placeholder integrity. However, the translation on line 3 contains an extra trailing whitespace that should be removed for consistency.- "Become a paid member of {site} to get access to all premium content.": "Legyen {site} előfizető, hogy minden értékes tartalmunkhoz hozzáférjen. ", + "Become a paid member of {site} to get access to all premium content.": "Legyen {site} előfizető, hogy minden értékes tartalmunkhoz hozzáférjen."
23-27
: Subscription Detail Messages and Whitespace Cleanup.
The extended subscription-related messages are translated accurately:
- Line 23: The message about the free trial ending is clear.
- Line 24: The cancellation notification maintains the original intent.
- Line 25: The expired subscription message is succinct.
- Line 26: Contains an extra trailing whitespace in the translation which should be removed for consistency.
- Line 27: The renewal message is correctly rendered.
- "Your subscription will expire on {date}.": "Az előfizetés lejáratának dátuma {date}. ", + "Your subscription will expire on {date}.": "Az előfizetés lejáratának dátuma {date}."
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ghost/i18n/locales/hu/newsletter.json
(1 hunks)
🔇 Additional comments (4)
ghost/i18n/locales/hu/newsletter.json (4)
7-10
: Email and Basic Interface Terms Translations.
The translations for the following keys are clear and appropriate:
- "Email" (line 7): Translated as "E-mail".
- "free" (line 8): Translated as "ingyenes".
- "Keep reading" (line 9): Translated as "Tovább olvasok".
- "Less like this" (line 10): Translated as "Kevesebb".
11-14
: Subscription Management Keys Translations.
The following keys related to subscription management are translated correctly:
- "Manage subscription" (line 11): "Előfizetés kezelése".
- "Member since" (line 12): "Előfizetés dátuma".
- "More like this" (line 13): "Több ilyet".
- "Name" (line 14): "Név".
15-17
: Subscription Status and Details Translations.
The translations for:
- "paid" (line 15): "fizetve".
- "Subscription details" (line 16): "Előfizetés részletei".
- "trialing" (line 17): "próbaidő alatt".
are clear and properly convey the intended meanings.
18-22
: Action-Oriented Content Translations.
The keys translated in this segment deal with actionable items and user notifications:
- "Unsubscribe" (line 18): "Leiratkozás".
- "Upgrade" (line 19): "Csomagváltás".
- "Upgrade to continue reading." (line 20): "Válts csomagot, hogy olvass tovább."
- "View in browser" (line 21): "Megnyitás böngészőben".
- The detailed subscriber message (line 22) preserves the HTML tags and placeholders correctly.
Thank you for this contribution! We actually already have work going on over in #21982 . Would you like to review that one, instead of starting a fresh one here? Thanks! |
Hey @agota1229 , #21982 has been merged. Could you please have a look at it (either the submitted files or live on your site in a few days) and see if you think additional work on the translations is needed? You could close this PR if no further work is necessary, or else if you want to use it to propose changes to the accepted changes, please start by using the "Resolve conflicts" button to bring your PR up to the current state of the translations. |
Everything provided with Hungarian translation
Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!
yarn test:all
andyarn lint
)We appreciate your contribution!