Moved email sender details to design settings table#28464
Conversation
|
It looks like this PR contains a migration 👀 General requirements
Schema changes
Data changes
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
57cad0c to
12978ca
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #28464 +/- ##
==========================================
+ Coverage 73.76% 73.77% +0.01%
==========================================
Files 1541 1541
Lines 132279 132257 -22
Branches 15804 15823 +19
==========================================
+ Hits 97576 97577 +1
+ Misses 33737 33691 -46
- Partials 966 989 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
towards https://linear.app/ghost/issue/NY-1308 This change should have no user impact. Automations no longer exposes this copied settings UI, so the duplicate posts components and stale copy comments can be removed. (cherry picked from commit 86c8ecf)
- `poll` no longer tells `MemberWelcomeEmailService` about sender details. - `MemberWelcomeEmailService` no longer accepts them. - Tests added/updated.
towards https://linear.app/ghost/issue/NY-1308 This change adds dormant sender fields to the `email_design_settings` table. (cherry picked from commit 97a94ee)
12978ca to
d639d18
Compare
closes https://linear.app/ghost/issue/NY-1308
closes https://linear.app/ghost/issue/NY-1333
ref #28461
ref #28326
I recommend reviewing this commit-by-commit.
Before this change, email sender details (sender address, name, and reply-to) were stored in two places:
welcome_email_automated_emailstableautomation_action_revisionstableNow, they're stored on the
email_design_settingstable.