Skip to content

Moved email sender details to design settings table#28464

Draft
EvanHahn wants to merge 11 commits into
mainfrom
2026-06-09-NY-1308
Draft

Moved email sender details to design settings table#28464
EvanHahn wants to merge 11 commits into
mainfrom
2026-06-09-NY-1308

Conversation

@EvanHahn

@EvanHahn EvanHahn commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

closes https://linear.app/ghost/issue/NY-1308
closes https://linear.app/ghost/issue/NY-1333
ref #28461
ref #28326

I recommend reviewing this commit-by-commit.

Before this change, email sender details (sender address, name, and reply-to) were stored in two places:

  1. The welcome_email_automated_emails table
  2. The automation_action_revisions table

Now, they're stored on the email_design_settings table.

@github-actions github-actions Bot added the migration [pull request] Includes migration for review label Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

It looks like this PR contains a migration 👀
Here's the checklist for reviewing migrations:

General requirements

  • ⚠️ Tested performance on staging database servers, as performance on local machines is not comparable to a production environment
  • Satisfies idempotency requirement (both up() and down())
  • Does not reference models
  • Filename is in the correct format (and correctly ordered)
  • Targets the next minor version
  • All code paths have appropriate log messages
  • Uses the correct utils
  • Contains a minimal changeset
  • Does not mix DDL/DML operations
  • Tested in MySQL and SQLite

Schema changes

  • Both schema change and related migration have been implemented
  • For index changes: has been performance tested for large tables
  • For new tables/columns: fields use the appropriate predefined field lengths
  • For new tables/columns: field names follow the appropriate conventions
  • Does not drop a non-alpha table outside of a major version

Data changes

  • Mass updates/inserts are batched appropriately
  • Does not loop over large tables/datasets
  • Defends against missing or invalid data
  • For settings updates: follows the appropriate guidelines

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d0a0ba54-201f-4d80-bd51-e9588e58d219

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-06-09-NY-1308

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EvanHahn EvanHahn force-pushed the 2026-06-09-NY-1308 branch 2 times, most recently from 57cad0c to 12978ca Compare June 10, 2026 15:18
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.63866% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.77%. Comparing base (d180686) to head (d639d18).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ore/server/api/endpoints/automated-email-design.js 96.49% 2 Missing ⚠️
...e/server/services/member-welcome-emails/service.js 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #28464      +/-   ##
==========================================
+ Coverage   73.76%   73.77%   +0.01%     
==========================================
  Files        1541     1541              
  Lines      132279   132257      -22     
  Branches    15804    15823      +19     
==========================================
+ Hits        97576    97577       +1     
+ Misses      33737    33691      -46     
- Partials      966      989      +23     
Flag Coverage Δ
admin-tests 54.67% <ø> (ø)
e2e-tests 73.77% <96.63%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EvanHahn EvanHahn force-pushed the 2026-06-09-NY-1308 branch from 12978ca to d639d18 Compare June 10, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

migration [pull request] Includes migration for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant