Skip to content

Removed unused automations email design modal#28487

Merged
EvanHahn merged 1 commit into
mainfrom
remove-unused-automations-email-design-modal
Jun 11, 2026
Merged

Removed unused automations email design modal#28487
EvanHahn merged 1 commit into
mainfrom
remove-unused-automations-email-design-modal

Conversation

@EvanHahn

@EvanHahn EvanHahn commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

closes https://linear.app/ghost/issue/NY-1330
towards https://linear.app/ghost/issue/NY-1308
ref d8ad698
ref https://linear.app/tryghost/issue/NY-1320

This change should have no user impact.

Automations no longer exposes this copied settings UI, so the duplicate posts components and stale copy comments can be removed.

towards https://linear.app/ghost/issue/NY-1308

This change should have no user impact.

Automations no longer exposes this copied settings UI, so the duplicate
posts components and stale copy comments can be removed.
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

This PR consolidates email design infrastructure by establishing admin-x-settings as the single source of truth. It introduces font configuration constants (FONT_OPTIONS, FONT_WEIGHT_OPTIONS, getValidWeight) and an EmailPreview component for rendering email designs with conditional headers, optional images, and configurable footers. The ButtonColorField component is re-established in admin-x-settings. Throughout the codebase, copy-paste documentation comments that explained prior code duplication between admin-x-settings and the posts app are removed, reflecting completion of the consolidation effort.

Suggested labels

ok to merge for me

Suggested reviewers

  • troyciesco
  • cmraible
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Removed unused automations email design modal' clearly and concisely describes the main change: removal of an unused modal and its associated components from the automations feature.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description clearly explains the changeset: removing unused email design modal components and stale copy comments from the automations section.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-unused-automations-email-design-modal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EvanHahn EvanHahn requested a review from cmraible June 10, 2026 15:15
@EvanHahn EvanHahn merged commit 3f91d2c into main Jun 11, 2026
48 checks passed
@EvanHahn EvanHahn deleted the remove-unused-automations-email-design-modal branch June 11, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants