Skip to content

CompatHelper: bump compat for ForwardDiff to 1 for package test, (keep existing compat) #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the ForwardDiff package from 0.10.12 to 0.10.12, 1 for package test.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@devmotion devmotion force-pushed the compathelper/new_version/2025-03-27-00-12-16-420-00270963760 branch from a97d5dc to 43e2232 Compare March 27, 2025 00:12
Copy link
Contributor Author

Benchmark Report for Commit 43e2232

Computer Information

Julia Version 1.11.4
Commit 8561cc3d68d (2025-03-10 11:36 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

|                 Model | Dimension |  AD Backend |      VarInfo Type | Linked | Eval Time / Ref Time | AD Time / Eval Time |
|-----------------------|-----------|-------------|-------------------|--------|----------------------|---------------------|
| Simple assume observe |         1 | forwarddiff |             typed |  false |                  9.8 |                 1.6 |
|           Smorgasbord |       201 | forwarddiff |             typed |  false |                645.7 |                39.6 |
|           Smorgasbord |       201 | forwarddiff | simple_namedtuple |   true |                433.6 |                45.1 |
|           Smorgasbord |       201 | forwarddiff |           untyped |   true |               1245.6 |                27.2 |
|           Smorgasbord |       201 | forwarddiff |       simple_dict |   true |               4290.5 |                18.9 |
|           Smorgasbord |       201 | reversediff |             typed |   true |               1493.5 |                29.5 |
|           Smorgasbord |       201 |    mooncake |             typed |   true |                963.9 |                 5.2 |
|    Loop univariate 1k |      1000 |    mooncake |             typed |   true |               5797.6 |                 4.0 |
|       Multivariate 1k |      1000 |    mooncake |             typed |   true |               1100.9 |                 8.5 |
|   Loop univariate 10k |     10000 |    mooncake |             typed |   true |              64140.1 |                 3.7 |
|      Multivariate 10k |     10000 |    mooncake |             typed |   true |               9176.2 |                 9.6 |
|               Dynamic |        10 |    mooncake |             typed |   true |                136.7 |                13.2 |
|              Submodel |         1 |    mooncake |             typed |   true |                 26.2 |                 7.3 |
|                   LDA |        12 | reversediff |             typed |   true |                457.8 |                 4.8 |

@yebai yebai changed the base branch from main to compathelper/new_version/2025-03-27-00-11-03-080-01636651742 March 28, 2025 00:20
@yebai yebai merged commit 1671cc6 into compathelper/new_version/2025-03-27-00-11-03-080-01636651742 Mar 28, 2025
3 of 16 checks passed
@yebai yebai deleted the compathelper/new_version/2025-03-27-00-12-16-420-00270963760 branch March 28, 2025 00:20
@penelopeysm
Copy link
Member

penelopeysm commented Mar 28, 2025

@yebai ReverseDiff still has a dependency on ForwardDiff = 0.10 JuliaDiff/ReverseDiff.jl#271 - I think this PR is blocked by that

/edit I meant to comment on #864 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants