Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForwardDiff -> 1 #871

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ForwardDiff -> 1 #871

wants to merge 1 commit into from

Conversation

penelopeysm
Copy link
Member

No description provided.

Copy link
Contributor

Benchmark Report for Commit 7f4e5d0

Computer Information

Julia Version 1.11.4
Commit 8561cc3d68d (2025-03-10 11:36 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

|                 Model | Dimension |  AD Backend |      VarInfo Type | Linked | Eval Time / Ref Time | AD Time / Eval Time |
|-----------------------|-----------|-------------|-------------------|--------|----------------------|---------------------|
| Simple assume observe |         1 | forwarddiff |             typed |  false |                  9.7 |                 1.5 |
|           Smorgasbord |       201 | forwarddiff |             typed |  false |                587.9 |                44.4 |
|           Smorgasbord |       201 | forwarddiff | simple_namedtuple |   true |                418.5 |                46.9 |
|           Smorgasbord |       201 | forwarddiff |           untyped |   true |               1210.5 |                28.9 |
|           Smorgasbord |       201 | forwarddiff |       simple_dict |   true |               4030.8 |                19.6 |
|           Smorgasbord |       201 | reversediff |             typed |   true |               1438.8 |                28.6 |
|           Smorgasbord |       201 |    mooncake |             typed |   true |                923.4 |                 5.3 |
|    Loop univariate 1k |      1000 |    mooncake |             typed |   true |               5363.9 |                 4.1 |
|       Multivariate 1k |      1000 |    mooncake |             typed |   true |               1120.4 |                 8.0 |
|   Loop univariate 10k |     10000 |    mooncake |             typed |   true |              59832.6 |                 3.7 |
|      Multivariate 10k |     10000 |    mooncake |             typed |   true |               8685.0 |                 9.8 |
|               Dynamic |        10 |    mooncake |             typed |   true |                135.5 |                13.8 |
|              Submodel |         1 |    mooncake |             typed |   true |                 25.8 |                 8.5 |
|                   LDA |        12 | reversediff |             typed |   true |                456.1 |                 8.3 |

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.87%. Comparing base (eed80e5) to head (7f4e5d0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #871   +/-   ##
=======================================
  Coverage   84.87%   84.87%           
=======================================
  Files          34       34           
  Lines        3815     3815           
=======================================
  Hits         3238     3238           
  Misses        577      577           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Mar 28, 2025

Pull Request Test Coverage Report for Build 14134335858

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1213 unchanged lines in 26 files lost coverage.
  • Overall coverage decreased (-0.6%) to 84.414%

Files with Coverage Reduction New Missed Lines %
src/DynamicPPL.jl 1 90.91%
src/submodel_macro.jl 2 82.35%
src/extract_priors.jl 5 53.57%
src/test_utils/model_interface.jl 5 22.22%
src/test_utils/varinfo.jl 5 78.26%
src/values_as_in_model.jl 6 43.9%
src/logdensityfunction.jl 7 64.44%
src/model_utils.jl 7 7.14%
src/distribution_wrappers.jl 13 9.76%
src/model.jl 13 80.0%
Totals Coverage Status
Change from base Build 14127923718: -0.6%
Covered Lines: 3217
Relevant Lines: 3811

💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 28, 2025

Pull Request Test Coverage Report for Build 14134335858

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1213 unchanged lines in 26 files lost coverage.
  • Overall coverage remained the same at 84.965%

Files with Coverage Reduction New Missed Lines %
src/DynamicPPL.jl 1 90.91%
src/submodel_macro.jl 2 82.35%
src/extract_priors.jl 5 53.57%
src/test_utils/model_interface.jl 5 22.22%
src/test_utils/varinfo.jl 5 78.26%
src/values_as_in_model.jl 6 43.9%
src/logdensityfunction.jl 7 64.44%
src/model_utils.jl 7 7.14%
src/distribution_wrappers.jl 13 9.76%
src/model.jl 13 80.0%
Totals Coverage Status
Change from base Build 14127923718: 0.0%
Covered Lines: 3238
Relevant Lines: 3811

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Mar 28, 2025

Pull Request Test Coverage Report for Build 14134335858

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1213 unchanged lines in 26 files lost coverage.
  • Overall coverage remained the same at 84.965%

Files with Coverage Reduction New Missed Lines %
src/DynamicPPL.jl 1 90.91%
src/submodel_macro.jl 2 82.35%
src/extract_priors.jl 5 53.57%
src/test_utils/model_interface.jl 5 22.22%
src/test_utils/varinfo.jl 5 78.26%
src/values_as_in_model.jl 6 43.9%
src/logdensityfunction.jl 7 64.44%
src/model_utils.jl 7 7.14%
src/distribution_wrappers.jl 13 9.76%
src/model.jl 13 80.0%
Totals Coverage Status
Change from base Build 14127923718: 0.0%
Covered Lines: 3238
Relevant Lines: 3811

💛 - Coveralls

@penelopeysm
Copy link
Member Author

penelopeysm commented Apr 1, 2025

CI is not resolving to ForwardDiff=1, so the green tick is not indicative of the compatibility.

Also it's likely we need to fix Bijectors upstream first: TuringLang/Bijectors.jl#378

@penelopeysm penelopeysm marked this pull request as draft April 1, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants