-
Notifications
You must be signed in to change notification settings - Fork 32
Implement AD testing and benchmarking (hand rolled) #882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+237
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Report for Commit b107b92Computer Information
Benchmark Results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #882 +/- ##
==========================================
- Coverage 84.92% 84.80% -0.13%
==========================================
Files 34 35 +1
Lines 3814 3843 +29
==========================================
+ Hits 3239 3259 +20
- Misses 575 584 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 14448023153Details
💛 - Coveralls |
5826564
to
b317ab2
Compare
sunxd3
reviewed
Apr 8, 2025
yebai
approved these changes
Apr 14, 2025
Thanks, @penelopeysm. This looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of two options. The other one at #883.
This PR implements functionality for testing and benchmarking AD. It is largely copied over from my ModelTests repo where I've been playing around with this.
Closes #869
What does it contain?
It basically adds one function
DynamicPPL.TestUtils.AD.run_ad
. See the docstring for more info.Why not an extension?
The only new dependencies are Statistics, which is stdlib, and Chairmarks, which itself has no non-stdlib dependencies. I therefore consider it unnecessary to add an extension (which would bring a number of drawbacks, e.g. reduced discoverability as users have to load the trigger packages themselves, us having to faff around with functions declared in
src/
and extended inext/
, ...)Why do I like this one more?
See #883.