Skip to content

Use generic type constants instead of manually written #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xukai92 opened this issue Apr 30, 2017 · 3 comments
Closed

Use generic type constants instead of manually written #215

xukai92 opened this issue Apr 30, 2017 · 3 comments

Comments

@xukai92
Copy link
Member

xukai92 commented Apr 30, 2017

We should gradually change things like 1.0 to one(T).
@yebai
Copy link
Member

yebai commented May 1, 2017

Good suggestion!

@xukai92 xukai92 mentioned this issue May 4, 2017
Closed
@xukai92
Copy link
Member Author

xukai92 commented May 8, 2017

Record: this commit ce94f19 improves generic typing for transforms.jl and utli.jl

@xukai92
Copy link
Member Author

xukai92 commented Jun 24, 2017

We have already done a lot on this and since in #293 we need to do the typing refactoring anyway so I'm going to close this issue.

@xukai92 xukai92 closed this as completed Jun 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yebai @xukai92