-
-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subpath support #908
base: master
Are you sure you want to change the base?
Add subpath support #908
Conversation
Is there a planned merge for this ? It would be great to have this available ! |
I believe the PWA manifest would need to be dynamic as well since it contains paths ( |
51ae352
to
3df20d8
Compare
Hi, Is there any update on this issue ? Thanks ! |
Hello, any chance to get this merged? I'm already using custom build with it but it would be nice to have this feature supported. Thanks Jan |
@TwiN Is there anything missing from this PR? |
I'm waiting for this feature ! |
export const SERVER_URL = process.env.NODE_ENV === 'production' ? '' : 'http://localhost:8080' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would break the ability to run the backend on :8080 while running the front-end on another port
(make run
followed by make frontend-run
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right. I'll take a look how this could be resolved
c1584a2
to
b8d699f
Compare
Summary
#88
Checklist
manifest.json
SERVER_URL
README.md
, if applicable.Caddy Configuration
Could certainly add another
redir
to serve/status
instead of/status/
🙂