Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subpath support #908

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Conversation

simonhammes
Copy link

@simonhammes simonhammes commented Nov 20, 2024

Summary

#88

Checklist

  • Verify manifest.json
  • Verify occurrences of SERVER_URL
  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

Caddy Configuration

:80 {    
    handle_path /status/* {
        reverse_proxy localhost:8080
    }
}

Could certainly add another redir to serve /status instead of /status/ 🙂

@rac021
Copy link

rac021 commented Nov 21, 2024

Is there a planned merge for this ?

It would be great to have this available !

@simonhammes
Copy link
Author

I believe the PWA manifest would need to be dynamic as well since it contains paths (start_url, icons)

@simonhammes simonhammes marked this pull request as ready for review December 1, 2024 22:10
@rac021
Copy link

rac021 commented Jan 14, 2025

Hi,

Is there any update on this issue ?

Thanks !

@semik
Copy link

semik commented Feb 10, 2025

Hello, any chance to get this merged? I'm already using custom build with it but it would be nice to have this feature supported. Thanks Jan

@simonhammes
Copy link
Author

@TwiN Is there anything missing from this PR?
I'd fix the merge conflicts if you're happy with the general idea. Thank you!

@orwithout
Copy link

I'm waiting for this feature !

Comment on lines -6 to -7
export const SERVER_URL = process.env.NODE_ENV === 'production' ? '' : 'http://localhost:8080'

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would break the ability to run the backend on :8080 while running the front-end on another port
(make run followed by make frontend-run)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right. I'll take a look how this could be resolved

@simonhammes simonhammes marked this pull request as draft February 25, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants