-
-
Notifications
You must be signed in to change notification settings - Fork 526
fix: allow opening another suggestion menu if another is triggered #1473 #1591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-docx-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I'm wondering while we're at it if we want it to be possible to have multiple suggestion menus to be open, instead of closing the existing one when a new one is opened. Currently, the emoji picker and slash menu clash if they're open together, so I think this would improve the UX.
@matthewlipski Can two be opened at the same time? Should they both be open at the same time? My understanding is only one should ever be active, and I think that is ideal from a UX standpoint. |
If you type |
Ah good catch @matthewlipski I'll try to resolve that |
Think I got it, abusing the fact that transactions are synchronous |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice fixes!
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This resolves #1473 by allowing the suggestion plugin to switch from one menu to another if it encounters another trigger character
Screen.Recording.2025-04-09.at.10.24.26.mov
This also resolves another issue I ran into personally.
If you type something that ends with
:
that menu is carried over to the new block, even though it shouldn't here is a video before & after.Before:
Screen.Recording.2025-04-09.at.10.22.51.mov
After:
Screen.Recording.2025-04-09.at.10.23.42.mov