Support h4, h5, and h6 #1634
Open
Support h4, h5, and h6 #1634
+795
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DrewJohnsonGT is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
|
@YousefED @nperez0111 is there anything else I should do here? |
|
Sorry for taking so long on this. Yea, this is mostly good, the one thing we would need to finish this up would be support in the export formats (e.g. PDF, ODT) |
|
@nperez0111 No worries! Took a quick stab at that just now ODT and Word defaults are alright I think? Word |
nperez0111
approved these changes
May 21, 2025
|
Nice! @nperez0111 need anything to get this merged? I think it might make sense to make the heading levels configurable? (e.g. simpler Notion style apps might have no need for some levels?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 1158
Screen.Recording.2025-04-23.at.1.56.28.PM.mov
Figure it doesn't make sense to add these as default/suggested blocks but adding general support will satisfy a lot of use cases
First contribution here, so let me know if I missed anything!
Re-opened with H6 as well per #1623 (comment)