feat: Merged getSelection and getSelectionCutBlocks
#1699
Conversation
- AI Menu items look more similar to Notion - `getDefaultAIMenuItems` uses same pattern as `getDefaultSlashMenuItems` - AI Block actually sets the `timeGenerated` prop after generating a response - AI Block only appears in the block type dropdown when the selection is in one - AI button in Formatting Toolbar now opens the AI Menu normally instead of in a popover
* Added right section to input and fixed AI UI * Implemented PR feedback * Fixed translations
* Added custom AI menu items example * Updated AI example READMEs
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| _meta: { | ||
| startPos: tr.selection.from, | ||
| endPos: tr.selection.to, | ||
| }, |
There was a problem hiding this comment.
I think this is useful to have, so let's just make it meta
| blocksCutAtStart: | ||
| startNode.nodeSize !== cutStartNode!.nodeSize | ||
| ? $startBlockBeforePos.nodeAfter!.attrs.id | ||
| : undefined, | ||
| blocksCutAtEnd: | ||
| endNode!.nodeSize !== cutEndNode!.nodeSize | ||
| ? $endBlockBeforePos.nodeAfter!.attrs.id | ||
| : undefined, |
There was a problem hiding this comment.
I'm still going to have to push back on this naming, I don't know what a blocksCutAtStart means.
There was a problem hiding this comment.
OK, I think I understand what cutBlocks are now from the tests. It is the slice of content that the selection range is over. imo, I don't think we should introduce another term on top of what prosemirror has already established for this (a slice).
I think it should be: blockSlice, I still don't understand the usefulness of blocksCutAtStart & blocksCutAtEnd, but I think it is something more like startBlockId or sliceBlockId
| node.type.name === startNode.type.name && | ||
| node.attrs.id === startNode.attrs.id |
There was a problem hiding this comment.
| node.type.name === startNode.type.name && | |
| node.attrs.id === startNode.attrs.id | |
| node.eq(startNode) |
There was a problem hiding this comment.
Ah maybe this won't match because it is the sliced node?
| node.type.name === endNode.type.name && | ||
| node.attrs.id === endNode.attrs.id |
There was a problem hiding this comment.
| node.type.name === endNode.type.name && | |
| node.attrs.id === endNode.attrs.id | |
| node.eq(endNode) |
| cutBlocks: Block<BSchema, I, S>[]; | ||
| blocksCutAtStart: string | undefined; | ||
| blocksCutAtEnd: string | undefined; | ||
| _meta: { |
There was a problem hiding this comment.
Can we add JSDoc to describe what each of these mean, and how they are different from each other?
This PR merges the currently 2 separate
getSelectionmethods into one.The functionality of
getSelectionis unchanged, only the additional fields fromgetSelectionCutBlockshave been added (withblocksrenamed tocutBlocks).getSelectionCutBlocksis slightly different as theblocksfield has been renamed tocutBlocksso as not to clash with the same field that was already ingetSelection. Also, now returnsundefinedwhen the selection is collapsed.TODO: