feat: enhance caching strategy for monorepos with smart install detection #174
+210
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING: Removes incorrect Turbo optimization that skipped yarn install The previous logic incorrectly assumed Turbo monorepos don't need yarn install on cache hits. This is FALSE for Yarn workspaces because: 1. Workspace symlinks are NOT preserved in GitHub Actions cache 2. Yarn creates symlinks between workspace packages during install 3. Without symlinks, workspace dependencies won't be found (jest: not found) 4. Turbo handles BUILD caching, not workspace linking 5. This is fast (~10-20s) because packages are cached This fix ensures yarn install always runs for Yarn workspaces, preventing 'module not found' errors in CI for bob-the-builder and other Turbo+Yarn repos.
|
This PR is missing a Jira ticket reference in the title or description. |
|
🥷 Code experts: no user but you matched threshold 10 kb-typeform has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the setup-node-with-cache action with comprehensive cache
integrity verification and verbose debugging to support the ongoing rollout
of centralized GitHub Actions across frontend projects.