Fix output path detection to correctly identify directories and files - #1556
Merged
Merged
Conversation
Tyrrrz
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to issue #1502
DiscordChatExporter/DiscordChatExporter.Core/Exporting/ExportRequest.cs
Lines 207 to 220 in acac8f7
Issue: You use
%Gat the end of a path with the guild name containing a period. The heuristic from the code snippet above identifies the resolved server name as a file path asPath.GetExtension(actualOutputPath)does not returnNull. DCE then tries to export all channels into this one file, e.g.,Discord.Test, leading to aSystem.IO.IOExceptiondue to concurrent access to one file by multiple processes if the export is parallelized.Solution: Evaluate the extension-based heuristic on the original, unsubstituted
outputPathinstead of the resolved path. The template path has no unwanted extension and therefore the user intent of creating a directory is preserved.