feat: creates DetailMedia component #846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- marks footer as already existing
pghorpade
approved these changes
Nov 5, 2025
| @@ -0,0 +1,12 @@ | |||
| describe('Funkhaus / DetailMedia', () => { | |||
| @@ -0,0 +1,184 @@ | |||
| import { computed } from 'vue' | |||
| @@ -0,0 +1,140 @@ | |||
| <script setup lang="ts"> | |||
Contributor
There was a problem hiding this comment.
Now that we have DLViewer migrated to Vue3 in this component library we dont need this file.
pghorpade
requested changes
Nov 5, 2025
Contributor
pghorpade
left a comment
pghorpade
left a comment
There was a problem hiding this comment.
comment left on the other message
pghorpade
requested changes
Nov 6, 2025
| @@ -0,0 +1,115 @@ | |||
| .detail-media, | |||
pghorpade
requested a deployment
to
netlify-preview
GitHub Actions
Waiting
pghorpade
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
github-actions
bot
temporarily deployed
to
storybook--pull_request_target-846
pghorpade
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
pghorpade
pushed a commit
that referenced
this pull request
Nov 7, 2025
# [@ucla-library-monorepo/ucla-library-website-components-v1.50.0](https://github.com/UCLALibrary/ucla-library-website-components/compare/@ucla-library-monorepo/ucla-library-website-components-v1.49.1...@ucla-library-monorepo/ucla-library-website-components-v1.50.0) (2025-11-07) ### Features * creates DetailMedia component ([#846](#846)) ([8891ff4](8891ff4))
Contributor
|
🎉 This PR is included in version @ucla-library-monorepo/ucla-library-website-components-v1.50.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component Created: DetailMedia.vue
Stories: ~/stories/DetailMedia.stories.js
Spec: ~/stories/DetailMedia.spec.js
Notes:
Checklist:
library-website-nuxt dev server