Open
Conversation
Code Style Violations Found
Total Violations: 11 Here are the formatting rules to follow:
Example of a long if condition violation:if (userDataProvider.isLoggedIn &&
(userDataProvider.userProfileModel.classifications?.staff ?? false)) {
// action
}// GOOD: split condition into variables for readability
var isLoggedIn = userDataProvider.isLoggedIn;
var isStaff = userDataProvider.userProfileModel.classifications?.staff ?? false;
if (isLoggedIn && isStaff) {
// action
}To see more details and fix these violations:
This comment will continue to appear until all violations are resolved. |
Contributor
|
Hold merge onto experimental branch, this will cause merge issues with the latest cma-tgpt code |
Code Style Violations Found
Total Violations: 11 Here are the formatting rules to follow:
Example of a long if condition violation:if (userDataProvider.isLoggedIn &&
(userDataProvider.userProfileModel.classifications?.staff ?? false)) {
// action
}// GOOD: split condition into variables for readability
var isLoggedIn = userDataProvider.isLoggedIn;
var isStaff = userDataProvider.userProfileModel.classifications?.staff ?? false;
if (isLoggedIn && isStaff) {
// action
}To see more details and fix these violations:
This comment will continue to appear until all violations are resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrate TritonGPT https://github.com/UCSD/campus-mobile/tree/cma-tgpt with existing code from experimental branch.
Changelog
[General] [Add] - Copy and added all changed files from the cma-tgpt branch by @NeuraByte-UCSD-ITS
Test Plan