-
Notifications
You must be signed in to change notification settings - Fork 280
refactor(ui5-side-navigation): allow long item texts to wrap instead of truncating #12577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
35da965
refactor(ui5-side-navigation): item texts wrap instead of truncating
s-todorova a097950
fix: public sample text
s-todorova 731aa64
Merge branch 'main' into sidenav_text_wrapping
s-todorova 3e31ba3
Merge branch 'main' into sidenav_text_wrapping
s-todorova ae2c7d4
Merge branch 'main' into sidenav_text_wrapping
s-todorova 2a71a79
Merge branch 'main' into sidenav_text_wrapping
s-todorova 7657329
Merge branch 'main' into sidenav_text_wrapping
s-todorova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>Side Navigation with Long Wrapping Texts</title> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no"> | ||
| <script src="%VITE_BUNDLE_PATH%" type="module"></script> | ||
| </head> | ||
|
|
||
| <body style="background-color: var(--sapBackgroundColor)"> | ||
| <ui5-side-navigation style="height: 90vh; " id="sn1"> | ||
| <ui5-side-navigation-item text="Home" | ||
| icon="home" | ||
| href="#home" | ||
| tooltip="Home tooltip"></ui5-side-navigation-item> | ||
| <ui5-side-navigation-group id="group1" expanded text="Group with very long text that should wrap" tooltip="Group tooltip"> | ||
| <!-- Items --> | ||
| <ui5-side-navigation-item text="Home 1 lorem ipsum dolor sit amet, consectetur adipiscing elit" | ||
| icon="home" | ||
| href="#home" | ||
| tooltip="Home 1 tooltip"></ui5-side-navigation-item> | ||
| <ui5-side-navigation-item text="People" href="#people" icon="group" tooltip="People tooltip"> | ||
| <ui5-side-navigation-sub-item text="From Other Teams lorem ipsum dolor sit amet, consectetur adipiscing elit" icon="employee-rejections"></ui5-side-navigation-sub-item> | ||
| </ui5-side-navigation-item> | ||
| <ui5-side-navigation-item text="People unselectable lorem ipsum dolor sit amet, consectetur adipiscing elit" href="#people" expanded unselectable icon="group" tooltip="People unselectable tooltip"> | ||
| <ui5-side-navigation-sub-item href="#disabled" text="Disabled" title="Disabled item tooltip"></ui5-side-navigation-sub-item> | ||
| <ui5-side-navigation-sub-item text="From Other Teams 2 lorem ipsum dolor sit amet, consectetur adipiscing elit"></ui5-side-navigation-sub-item> | ||
| </ui5-side-navigation-item> | ||
| <ui5-side-navigation-item text="Service Management and Customer Support Operations" href="#people" expanded unselectable icon="group" tooltip="People unselectable tooltip"> | ||
| <ui5-side-navigation-sub-item href="#disabled" text="Disabled" title="Service Tickets and Customer Issue Resolution"></ui5-side-navigation-sub-item> | ||
| <ui5-side-navigation-sub-item text="From Other Teams 2 lorem ipsum dolor sit amet, consectetur adipiscing elit"></ui5-side-navigation-sub-item> | ||
| </ui5-side-navigation-item> | ||
| </ui5-side-navigation-group> | ||
| <ui5-side-navigation-item href="#locations" text="Locations" icon="locate-me" ></ui5-side-navigation-item> | ||
| <ui5-side-navigation-item href="#events" expanded text="Events lorem ipsum dolor sit amet, consectetur adipiscing elit" icon="calendar"> | ||
| <ui5-side-navigation-sub-item href="#page1" target="_self" text="Local lorem ipsum dolor sit amet, consectetur adipiscing elit"></ui5-side-navigation-sub-item> | ||
| <ui5-side-navigation-sub-item text="Others" selected></ui5-side-navigation-sub-item> | ||
| </ui5-side-navigation-item> | ||
| <ui5-side-navigation-item href="#locations" text="Locations 2 lorem ipsum dolor sit amet, consectetur adipiscing elit" icon="locate-me"></ui5-side-navigation-item> | ||
| <ui5-side-navigation-group expanded text="Group 2 lorem ipsum dolor sit amet, consectetur adipiscing elit"> | ||
| <!-- Items --> | ||
| <ui5-side-navigation-item text="Home 1 lorem ipsum dolor sit amet, consectetur adipiscing elit" | ||
| icon="home" | ||
| href="#home" | ||
| title="Home tooltip"></ui5-side-navigation-item> | ||
| <ui5-side-navigation-item text="People 2 lorem ipsum dolor sit amet, consectetur adipiscing elit" href="#people" expanded icon="group"> | ||
| <ui5-side-navigation-sub-item href="#disabled" disabled text="Disabled lorem ipsum dolor sit amet, consectetur adipiscing elit" icon="employee-approvals" title="From My Team tooltip"></ui5-side-navigation-sub-item> | ||
| <ui5-side-navigation-sub-item text="From Other Teams 3 lorem ipsum dolor sit amet, consectetur adipiscing elit" icon="employee-rejections"></ui5-side-navigation-sub-item> | ||
| </ui5-side-navigation-item> | ||
| </ui5-side-navigation-group> | ||
| <ui5-side-navigation-group expanded text="Group 2 1"> | ||
| <!-- Items --> | ||
| <ui5-side-navigation-item text="Home 1" | ||
| icon="home" | ||
| href="#home" | ||
| title="Home tooltip"></ui5-side-navigation-item> | ||
| <ui5-side-navigation-item text="People" href="#people" expanded icon="group"> | ||
| <ui5-side-navigation-sub-item href="#disabled" disabled text="Disabled" icon="employee-approvals" title="From My Team tooltip"></ui5-side-navigation-sub-item> | ||
| <ui5-side-navigation-sub-item text="From Other Teams 4" icon="employee-rejections"></ui5-side-navigation-sub-item> | ||
| </ui5-side-navigation-item> | ||
| </ui5-side-navigation-group> | ||
| <ui5-side-navigation-item href="#page1" target="_self" text="Locations 25" icon="group"> | ||
| <ui5-side-navigation-sub-item icon="home" href="#page1" target="_self" text="Local lorem ipsum dolor sit amet, consectetur adipiscing elit"></ui5-side-navigation-sub-item> | ||
| <ui5-side-navigation-sub-item icon="female" text="Others lorem ipsum dolor sit amet, consectetur adipiscing elit"></ui5-side-navigation-sub-item> | ||
| </ui5-side-navigation-item> | ||
| <ui5-side-navigation-group expanded text="Group 3"> | ||
| <ui5-side-navigation-item text="Home 10" icon="home" href="#home" tooltip="Home 10 tooltip"></ui5-side-navigation-item> | ||
| <ui5-side-navigation-item text="People" href="#people" expanded icon="group" tooltip="People tooltip"> | ||
| <ui5-side-navigation-sub-item href="#disabled" disabled text="Disabled" icon="employee-approvals" tooltip="Disabled item tooltip"></ui5-side-navigation-sub-item> | ||
| <ui5-side-navigation-sub-item text="From Other Teams 5" icon="employee-rejections" tooltip="From Other Teams 5 tooltip"></ui5-side-navigation-sub-item> | ||
| </ui5-side-navigation-item> | ||
| </ui5-side-navigation-group> | ||
| <!-- Fixed Items --> | ||
| <ui5-side-navigation-item slot="fixedItems" text="Quick Create" icon="write-new" design="Action" unselectable id="quickCreate" tooltip="Quick Create Tooltip"></ui5-side-navigation-item> | ||
| <ui5-side-navigation-item slot="fixedItems" text="Quick Create lorem ipsum dolor sit amet, consectetur adipiscing elit" icon="write-new" design="Action" unselectable id="quickCreate2" tooltip="Quick Create Tooltip"></ui5-side-navigation-item> | ||
| <ui5-side-navigation-item slot="fixedItems" text="Useful Links" icon="chain-link" title="Useful links tooltip"> | ||
| <ui5-side-navigation-sub-item text="Vacation Tool" title="Vacation Tool tooltip"></ui5-side-navigation-sub-item> | ||
| <ui5-side-navigation-sub-item text="HR tool"></ui5-side-navigation-sub-item> | ||
| </ui5-side-navigation-item> | ||
| <ui5-side-navigation-item slot="fixedItems" text="History lorem ipsum dolor sit amet, consectetur adipiscing elit" icon="history"></ui5-side-navigation-item> | ||
| </ui5-side-navigation> | ||
|
|
||
| <div style="float: right"> | ||
| <ui5-checkbox id="collapsed" text="Collapsed"></ui5-checkbox> | ||
| <ui5-checkbox id="density" text="Compact density"></ui5-checkbox> | ||
| <br> | ||
| <ui5-label for="slider" show-colon>Change width</ui5-label> | ||
| <ui5-slider id="slider" value="0" min="0" max="600" step="50" show-tickmarks label-interval="2"></ui5-slider> | ||
| </div> | ||
|
|
||
| <script> | ||
| const sn = document.getElementById("sn1"); | ||
|
|
||
| const collapsedBtn = document.getElementById("collapsed"); | ||
|
|
||
| collapsedBtn.addEventListener("change", e => { | ||
| sn.toggleAttribute("collapsed", e.target.checked); | ||
| }); | ||
|
|
||
| const densityBtn = document.getElementById("density"); | ||
| density.addEventListener("change", e => { | ||
| document.body.classList.toggle("ui5-content-density-compact", e.target.checked); | ||
| }); | ||
|
|
||
| slider.addEventListener("ui5-input", function (event) { | ||
| sn1.style.width = event.target.value + 'px'; | ||
| }); | ||
| </script> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.