Skip to content

Conversation

@GDamyanov
Copy link
Contributor

@GDamyanov GDamyanov commented Nov 24, 2025

  • Calendar header navigation buttons are now focusable via keyboard (tabindex set).
  • Each header button has a descriptive title attribute for improved accessibility and user guidance.

@ui5-webcomponents-bot
Copy link
Collaborator

ui5-webcomponents-bot commented Nov 24, 2025

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 24, 2025 15:10 Inactive
@GDamyanov GDamyanov changed the title feat(ui5-calendar): enhance component accessibility feat(ui5-calendar): improve header and day picker accessibility and focus behavior Nov 24, 2025
@GDamyanov GDamyanov self-assigned this Nov 24, 2025
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 24, 2025 15:45 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 24, 2025 19:14 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 25, 2025 12:41 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 25, 2025 13:24 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 8, 2025 17:27 Inactive
@GDamyanov GDamyanov marked this pull request as ready for review December 8, 2025 17:33
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 8, 2025 17:38 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 8, 2025 18:30 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 9, 2025 09:53 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 9, 2025 10:15 Inactive
@GDamyanov GDamyanov requested a review from unazko December 10, 2025 11:20
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 10, 2025 11:31 Inactive
Copy link
Contributor

@unazko unazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the code is clean.
I've found the following behavioural issue:

  • Right mouse click triggers the previous/next button's action

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 16, 2025 10:28 Inactive
Copy link
Contributor

@unazko unazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good in my perspective.

There is one last issue:

  • In the year range view the next/previous button tooltips should refer to year ranges instead of months.

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 17, 2025 07:21 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 17, 2025 09:01 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 17, 2025 09:18 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants