-
Notifications
You must be signed in to change notification settings - Fork 279
feat(ui5-calendar): improve header and day picker accessibility and focus behavior #12712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
🚀 Deployed on https://pr-12712--ui5-webcomponents-preview.netlify.app |
unazko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the code is clean.
I've found the following behavioural issue:
- Right mouse click triggers the previous/next button's action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good in my perspective.
There is one last issue:
- In the year range view the next/previous button tooltips should refer to year ranges instead of months.
Uh oh!
There was an error while loading. Please reload this page.