Implement file size limit in the PostObject method of api/controllers/storage.go for cloud storage.#380
Merged
Merged
Conversation
mikehquan19
requested changes
Apr 15, 2026
Contributor
mikehquan19
left a comment
mikehquan19
left a comment
There was a problem hiding this comment.
Hey @SiddhaarthB11 , this looks good, especially with the unit-tests! However, I just need some clarification in the upload size limiting approach.
TyHil
requested changes
Apr 15, 2026
Member
TyHil
left a comment
TyHil
left a comment
There was a problem hiding this comment.
Just a couple more things I noticed, looking good tho
Contributor
|
@SiddhaarthB11 Could you help me resolve the merge conflicts in the env example file? It shouldn't be so hard. |
mikehquan19
approved these changes
Apr 29, 2026
Contributor
mikehquan19
left a comment
mikehquan19
left a comment
There was a problem hiding this comment.
Ok! LGTM now. Great job with the signed url as well, I didn't expect that.
Contributor
|
@TyHil Can you check if everything is alright? The solution to upload size for signed url turns out to be really neat. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.