Add multi email recipients#393
Merged
Merged
Conversation
mikehquan19
previously approved these changes
Apr 23, 2026
Contributor
mikehquan19
left a comment
mikehquan19
left a comment
There was a problem hiding this comment.
Just some questions, should be okay now
Contributor
|
Nvm you mentioned the concerns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The email endpoint should have a way to send emails to multiple recipients with one request.
To avoid hitting any SMTP limits, multi recipient emails are not allowed for
/email/queue, so having more than one string in the "to" array results in a google cloud task being created for each recipient./email/senddoes allow multi recipients in one email, but probably shouldn't be used that way since it bypasses the queueing and could cause the api to hit the SMTP limit.I'm not 100% on how I've implemented this PR, so I can definitely make any changes if we want a different behavior for multi-recipients.