Add single note display page with details and PDF viewer#135
Open
iffy1234 wants to merge 1 commit intoUTDNebula:developfrom
Open
Add single note display page with details and PDF viewer#135iffy1234 wants to merge 1 commit intoUTDNebula:developfrom
iffy1234 wants to merge 1 commit intoUTDNebula:developfrom
Conversation
|
@iffy1234 is attempting to deploy a commit to the Nebula Labs Team on Vercel. A member of the Team first needs to authorize it. |
iffy1234
force-pushed
the
feature/single-notes-page
branch
from
0387587 to
d3503c9
Compare
TyHil
requested changes
Mar 17, 2026
Member
TyHil
left a comment
TyHil
left a comment
There was a problem hiding this comment.
Nice, looking good! In general try not to force push but I think there's just 2 sections of the code that got removed accidentally to be restored and this will be done. You can see the full text of what got removed here: https://github.com/UTDNebula/utd-notebook/pull/135/changes
| throw e; | ||
| } | ||
| }), | ||
| byAuthor: protectedProcedure |
Comment on lines
-178
to
-181
| await Promise.all([ | ||
| callStorageAPI('DELETE', file.id), | ||
| ctx.db.delete(files).where(eq(files.id, input.id)), | ||
| ]); |
Member
There was a problem hiding this comment.
Restore the Promise.all wrapping these function calls
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #118
What changed
src/app/notes/[id]/page.tsxiframeNotes