Skip to content

refactor(apollo-vertex): use async/await in i18n backend read#483

Merged
KokoMilev merged 1 commit intomainfrom
refactor/i18-async-await
Apr 10, 2026
Merged

refactor(apollo-vertex): use async/await in i18n backend read#483
KokoMilev merged 1 commit intomainfrom
refactor/i18-async-await

Conversation

@KokoMilev
Copy link
Copy Markdown
Contributor

No description provided.

@KokoMilev KokoMilev requested a review from a team as a code owner April 10, 2026 07:57
@KokoMilev KokoMilev requested review from angeloaltamiranom, Copilot and pieman1313 and removed request for a team April 10, 2026 07:57
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-canvas 🟢 Ready Preview, Logs Apr 10, 2026, 01:01:15 AM
apollo-landing 🟢 Ready Preview, Logs Apr 10, 2026, 01:00:03 AM
apollo-ui-react 🟢 Ready Preview, Logs Apr 10, 2026, 01:00:34 AM
apollo-vertex 🟢 Ready Preview, Logs Apr 10, 2026, 01:01:08 AM
apollo-wind 🟢 Ready Preview, Logs Apr 10, 2026, 12:59:58 AM

@KokoMilev KokoMilev enabled auto-merge (rebase) April 10, 2026 07:58
@KokoMilev KokoMilev marked this pull request as draft April 10, 2026 07:58
auto-merge was automatically disabled April 10, 2026 07:58

Pull request was converted to draft

@github-actions github-actions bot added the size:S 10-29 changed lines. label Apr 10, 2026
@github-actions
Copy link
Copy Markdown

Dependency License Review

  • 1948 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 4 package(s) excluded (see details below)
License distribution
License Packages
MIT 1707
ISC 89
Apache-2.0 61
BSD-3-Clause 28
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 5
MIT OR Apache-2.0 3
MIT-0 3
CC0-1.0 3
LGPL-3.0-or-later 2
Unknown 2
(MIT OR Apache-2.0) 2
Unlicense 2
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
@img/sharp-libvips-linuxmusl-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
@uipath/proteus-client 0.1.10 Unknown UiPath internal package, Proprietary license
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

@KokoMilev KokoMilev force-pushed the refactor/i18-async-await branch from 271788e to 2b3dee2 Compare April 10, 2026 07:58
@KokoMilev KokoMilev marked this pull request as ready for review April 10, 2026 07:58
@KokoMilev KokoMilev enabled auto-merge (rebase) April 10, 2026 07:58
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors Apollo Vertex’s i18next backend loader to use async/await and updates the Next.js environment typings import path.

Changes:

  • Convert the i18next backend read implementation from .then/.catch to async/await while preserving callback behavior.
  • Update next-env.d.ts to import route types from a different .next subpath.

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

File Description
apps/apollo-vertex/next-env.d.ts Changes the generated route types import path used by TypeScript.
apps/apollo-vertex/lib/i18n.ts Refactors locale module loading in the i18next backend to async/await.

@KokoMilev KokoMilev merged commit 9026a9b into main Apr 10, 2026
48 of 49 checks passed
@KokoMilev KokoMilev deleted the refactor/i18-async-await branch April 10, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants