refactor(apollo-vertex): use async/await in i18n backend read#483
Merged
refactor(apollo-vertex): use async/await in i18n backend read#483
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
271788e to
2b3dee2
Compare
frankkluijtmans
approved these changes
Apr 10, 2026
There was a problem hiding this comment.
Pull request overview
Refactors Apollo Vertex’s i18next backend loader to use async/await and updates the Next.js environment typings import path.
Changes:
- Convert the i18next backend
readimplementation from.then/.catchtoasync/awaitwhile preserving callback behavior. - Update
next-env.d.tsto import route types from a different.nextsubpath.
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/apollo-vertex/next-env.d.ts | Changes the generated route types import path used by TypeScript. |
| apps/apollo-vertex/lib/i18n.ts | Refactors locale module loading in the i18next backend to async/await. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.