Preview: depostulate axioms #1380
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgbertRijke
reviewed
Mar 24, 2025
| @@ -115,7 +115,7 @@ def filter_agda_files(f): return utils.is_agda_file(pathlib.Path(f)) and os.path | |||
|
|
|||
| temp_dir = 'temp' | |||
| status = 0 | |||
| agda_options = '--without-K --exact-split --no-import-sorts --auto-inline --no-caching' | |||
| agda_options = '--without-K --exact-split --no-import-sorts --auto-inline --no-caching -WnoPatternShadowsConstructor' | |||
There was a problem hiding this comment.
Why wouldn't we want these warnings?
Also, is the question of including this pragma orthogonal to the purpose of this pull request, or am I missing something?
There was a problem hiding this comment.
Ah, I thought this pragma promoted the warning to an error. It is orthogonal to this PR, but not to #1373 on which it depends
There was a problem hiding this comment.
(There it caused errors in the file elementary-number-theory.multiplication-integers)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a preview of what the library might look like with depostulated axioms.
Depends on #1373
#1379