Absolute value on rational numbers #1381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2025
fredrik-bakke
added a commit
that referenced
this pull request
Mar 27, 2025
Doesn't have nearly as much content as #1381 , but that's because we don't even have addition yet on the real numbers. Still, this is, I think, enough to continue on #1353 . --------- Co-authored-by: Fredrik Bakke <[email protected]>
src/elementary-number-theory/absolute-value-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/absolute-value-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/nonnegative-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/nonnegative-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/nonnegative-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/nonnegative-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/nonnegative-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
src/elementary-number-theory/nonnegative-rational-numbers.lagda.md
Outdated
Show resolved
Hide resolved
fredrik-bakke
approved these changes
Mar 30, 2025
Co-authored-by: Fredrik Bakke <[email protected]>
…a.md Co-authored-by: Fredrik Bakke <[email protected]>
|
Nice work on the simplification! Do you intend to continue work in this PR before it is merged? Otherwise, could you fix the final comment so we can merge? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds atop #1351 and the negative/nonnegative rationals work done there to support the absolute value and prove the lemmas described as necessary in #1353 .