Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: [2.X] CI failures fixes #3302

Draft
wants to merge 14 commits into
base: develop-2.0.0
Choose a base branch
from
Draft

ci: [2.X] CI failures fixes #3302

wants to merge 14 commits into from
+93 −43

Conversation

michalChrobot
Copy link
Collaborator

@michalChrobot michalChrobot commented Feb 18, 2025 •
edited
Loading

This PR addresses some test failures in new CI definition (present on develop-2.0.0 branch)

  1. Code Coverage test failure --> This test was failing because packed package couldn't be find. This steams from the fact that the path was wrongly pointing to different place because package pack job was modified to use upm-pvp instead of upm-ci. In this PR this test is corrected and changed to also use upm-pvp.
  2. minimalproject standards failure --> We were focusing before on making sure that testproject is conforming to standards (which also means that NGO package conforms to standards) but minimalproject has few errors which we aim to fix in this PR
  3. testproject-tools-integration standards failure --> We were focusing before on making sure that testproject is conforming to standards (which also means that NGO package conforms to standards) but testproject-tools-integration has few errors which we aim to fix in this PR

@michalChrobot michalChrobot self-assigned this Feb 18, 2025
@michalChrobot michalChrobot mentioned this pull request Feb 18, 2025
Closed
michalChrobot and others added 3 commits February 18, 2025 11:35
@michalChrobot
Linter correction
a087bbe
@NoelStephensUnity
fix
801297c 
Fixing standards checks issues.
Fixing issue with using the upm candidates.
@NoelStephensUnity
fix
4598705 
Adding Rider editor support for standards checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoelStephensUnity NoelStephensUnity NoelStephensUnity approved these changes

@miniwolf miniwolf Awaiting requested review from miniwolf miniwolf will be requested when the pull request is marked ready for review miniwolf is a code owner

@fluong6 fluong6 Awaiting requested review from fluong6 fluong6 will be requested when the pull request is marked ready for review fluong6 is a code owner

@EmandM EmandM Awaiting requested review from EmandM EmandM will be requested when the pull request is marked ready for review EmandM is a code owner

Assignees

@michalChrobot michalChrobot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalChrobot @NoelStephensUnity