Skip to content

Use test settings so #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sindharta wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Use test settings so #703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4147800
add UTSGraphicsComponent if the scene doesn't have it
sindharta Dec 29, 2025
a6085a6
use Resources
sindharta Dec 29, 2025
714c73d
use resources.load
sindharta Dec 29, 2025
b57db1e
skip memory allocation check entirely
sindharta Dec 29, 2025
64d7f10
add TODO
sindharta Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions com.unity.toon-graphics-test/Runtime/Resources.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 ...cs-test/Runtime/UTSGraphicsSettings.asset → ...ntime/Resources/UTSGraphicsSettings.asset
View file
Open in desktop
File renamed without changes.
0 ...st/Runtime/UTSGraphicsSettings.asset.meta → .../Resources/UTSGraphicsSettings.asset.meta
View file
Open in desktop
File renamed without changes.
35 changes: 12 additions & 23 deletions com.unity.toon-graphics-test/Runtime/UTSGraphicsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,11 @@ internal static IEnumerator RunInternal(GraphicsTestCase testCase, bool isXR = f
yield return null;

Camera mainCamera = GameObject.FindGameObjectWithTag("MainCamera").GetComponent<Camera>();
UTSGraphicsTestSettings settings = Object.FindFirstObjectByType<UTSGraphicsTestSettings>();
Assert.IsNotNull(settings, "Invalid test scene, couldn't find UTS_GraphicsTestSettings");

UTSGraphicsTestSettingsSO settingsSO = settings.SO;
Assert.IsNotNull(settingsSO);


//"Packages/com.unity.toon-graphics-test/Runtime/Resources/UTSGraphicsSettings.asset";
UTSGraphicsTestSettingsSO settingsSO = Resources.Load<UTSGraphicsTestSettingsSO>("UTSGraphicsSettings");
Assert.IsNotNull(settingsSO, "[UTS Graphics Test] Settings not found");

ImageComparisonSettings imageComparisonSettings = settingsSO.ImageComparisonSettings;
Assert.IsNotNull(imageComparisonSettings);

Expand Down Expand Up @@ -117,23 +116,13 @@ internal static IEnumerator RunInternal(GraphicsTestCase testCase, bool isXR = f

ImageAssert.AreEqual(testCase.ReferenceImage, mainCamera,
imageComparisonSettings, testCase.ReferenceImagePathLog);

// Does it allocate memory when it renders what's on the main camera?
bool allocatesMemory = false;

if (settings == null || settings.CheckMemoryAllocation)
{
try
{
ImageAssert.AllocatesMemory(mainCamera, imageComparisonSettings);
}
catch (AssertionException)
{
allocatesMemory = true;
}
if (allocatesMemory)
Assert.Fail("Allocated memory when rendering what is on main camera");
}

// [TODO-sin: 2025-12-23] Check memory allocations
// try {
// ImageAssert.AllocatesMemory(mainCamera, imageComparisonSettings);
// } catch (AssertionException) {
// Assert.Fail("Allocated memory when rendering what is on main camera");
// }
}
}

Expand Down