refactor: clarify that SetupTransparentMode() configures transparency for outline rendering #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR refactors the SetupTransparentMode function to be more specific to outline rendering, removing unused legacy code and improving code clarity. The changes focus on consolidating SRP-specific logic and making the naming more descriptive.
Key Changes:
- Removed the unused
srpDefaultLightModeNameproperty that handled legacy render pipeline logic - Renamed
SetupTransparentModetoSetupTransparentModeForOutlineto better reflect its purpose - Added SRP-specific preprocessor guards and improved inline documentation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| com.unity.toonshader/Editor/UTS3GUI.cs | Removed srpDefaultLightModeName property, renamed function to SetupTransparentModeForOutline, added preprocessor guards, and improved variable naming with inline comments |
| com.unity.toonshader/Editor/Converter/FromUTS2/BuiltInUTS2toIntegratedConverter.cs | Updated function call to use the renamed SetupTransparentModeForOutline method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const string srpDefaultColorMask = "_SPRDefaultUnlitColorMask"; | ||
| const string srpDefaultCullMode = "_SRPDefaultUnlitColMode"; | ||
| const string OUTLINE_COLOR_MASK = "_SPRDefaultUnlitColorMask"; | ||
| const string OUTLINE_CULL_MODE = "_SRPDefaultUnlitColMode"; |
There was a problem hiding this comment.
Corrected spelling of 'Col' to 'Cull' in constant name.
Suggested change
| const string OUTLINE_CULL_MODE = "_SRPDefaultUnlitColMode"; | |
| const string OUTLINE_CULL_MODE = "_SRPDefaultUnlitCullMode"; |
sindharta
changed the title
sindharta
changed the title
sindharta
changed the title
sindharta
force-pushed
the
srpdefault
branch
from
bd8d362 to
a1ded8e
Compare
sindharta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.